Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC Refactor #182

Merged
merged 5 commits into from
Nov 26, 2024
Merged

RPC Refactor #182

merged 5 commits into from
Nov 26, 2024

Conversation

cmmarslender
Copy link
Contributor

@cmmarslender cmmarslender commented Nov 26, 2024

  • Return ChiaRPCError of the request succeeds but the RPC returns success: false
  • Add a generic Do() helper that reduces boilerplate required when adding additional endpoints

…error. Always return the response object even if there's an error in the response since there is still useful information sometimes
@cmmarslender cmmarslender changed the title Return a ChiaRPCError if the request succeeds but the RPC returns an … RPC Refactor Nov 26, 2024
@cmmarslender cmmarslender merged commit c80025e into main Nov 26, 2024
7 checks passed
@cmmarslender cmmarslender deleted the rpc-refactor branch November 26, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants