Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework the websocket client with new sync mode + more intuitive usage patterns + add daemon service #113

Merged
merged 7 commits into from
Mar 16, 2024
Merged

Rework the websocket client with new sync mode + more intuitive usage patterns + add daemon service #113

merged 7 commits into from
Mar 16, 2024

Conversation

cmmarslender
Copy link
Contributor

  • Adds sync mode option to websocket client, to allow it to act more like the request/response HTTP client
  • Add daemon service (available only via websocket)
  • get_network_info endpoint on daemon service
  • Add ability to remove a registered websocket handler

@cmmarslender
Rework the websocket mode to be a bit more intuiative to use + add a …
4e4e92f 
…sync mode + ability to remove handlers after they're registered

Sync mode will cause the rpc function calls to wait for their response before returning (request/response style calls vs async handlers)
@cmmarslender
Add daemon service
15dba2b
@cmmarslender
Update readme with new websocket usage patterns
0217181
@cmmarslender cmmarslender enabled auto-merge (squash) March 16, 2024 21:23
@cmmarslender cmmarslender disabled auto-merge March 16, 2024 21:53
@cmmarslender
Make error messages a bit more detailed
7064263
@cmmarslender
Return errors from any methods that try to do something specifically …
90ca974 
…not supported by the HTTP client, leave nil return as implied/only-option type functions
@cmmarslender cmmarslender merged commit 71666e5 into main Mar 16, 2024
5 checks passed
@cmmarslender cmmarslender deleted the websocket-rework branch March 16, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starttoaster Starttoaster Starttoaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmmarslender @Starttoaster