Update plotter_disk.hpp #202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the rlimit also on Linux was necessary to make it work with 1024 buckets plus changing the number from 600 to 4096.
arvidn
requested changes
Apr 1, 2021
| @@ -73,12 +73,11 @@ class DiskPlotter { | |||
| bool show_progress = false) | |||
| { | |||
| // Increases the open file limit, we will open a lot of files. | |||
| #ifndef _WIN32 | |||
There was a problem hiding this comment.
you need to put these #ifndef back. Note the n in there, this condition is to omit this code on windows, because windows doesn't have rlimits. (this is why this patch fails to build on windows, here)
|
I would also suggest to make the commit message more descriptive, e.g. "Increase file descriptor limit" |
|
'This PR has been flagged as stale due to no activity for over 60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the rlimit also on Linux was necessary to make it work with 1024 buckets plus changing the number from 600 to 4096.