Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more less default root path #19031

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

altendky
Copy link
Contributor

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky requested a review from a team as a code owner December 11, 2024 20:18
@altendky altendky added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Dec 11, 2024
Quexington
Quexington previously approved these changes Dec 11, 2024
Copy link
Contributor

@Quexington Quexington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changes but all very simple and in the same vein

Quexington
Quexington previously approved these changes Dec 11, 2024
@altendky altendky requested a review from emlowe December 12, 2024 00:00
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Dec 12, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Dec 12, 2024
Copy link

Pull Request Test Coverage Report for Build 12300380380

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 169 of 169 (100.0%) changed or added relevant lines in 7 files are covered.
  • 11 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.04%) to 91.511%

Files with Coverage Reduction New Missed Lines %
chia/daemon/server.py 1 83.24%
chia/plotters/plotters.py 1 90.94%
chia/cmds/wallet.py 1 97.59%
chia/server/node_discovery.py 2 81.65%
chia/plotters/madmax.py 6 44.58%
Totals Coverage Status
Change from base Build 12300267775: 0.04%
Covered Lines: 104750
Relevant Lines: 114276

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants