Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): fix child modules parse tfplan file #7266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nirfirefly
Copy link

@nirfirefly nirfirefly commented Oct 3, 2024

Closes #7265

Reason for Proposed Changes

  • When pasrsing tfplan file:
    If there are child modules, each child module overrides the resources in the module above it

Proposed Changes

  • initialize the resource map only once
  • use address as resource identifier, as the name is only unique in a module.

I submit this contribution under the Apache-2.0 license.

@nirfirefly nirfirefly requested a review from a team as a code owner October 3, 2024 21:10
@github-actions github-actions bot added the community Community contribution label Oct 3, 2024
@nirfirefly nirfirefly changed the title Fix child modules parse tfplan file bug(terraform): Fix child modules parse tfplan file Oct 3, 2024
@github-actions github-actions bot added bug Something isn't working terraform Terraform query labels Oct 3, 2024
@nirfirefly nirfirefly changed the title bug(terraform): Fix child modules parse tfplan file bug(terraform): fix child modules parse tfplan file Oct 4, 2024
@nirfirefly nirfirefly changed the title bug(terraform): fix child modules parse tfplan file fix(terraform): fix child modules parse tfplan file Oct 4, 2024
@github-actions github-actions bot removed the bug Something isn't working label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution terraform Terraform query
Projects
None yet
1 participant