Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved postgres DB credentials to .env file addressing issue #67 #140

Merged

Conversation

Deekshithrathod
Copy link
Contributor

@Deekshithrathod Deekshithrathod commented Jul 7, 2023

Address the issue #67

  1. Moved out the sensitive information like DB username & password to a .env file
  2. Added a .env.example file to copy the credentials from when setting up locally

Additional Todos,

  • update onboarding documentation asking the user to create a .env file & copying the creds from .env.example

@Deekshithrathod Deekshithrathod changed the title moved postgres DB credentials to .env file moved postgres DB credentials to .env file addressing issue #67 Jul 7, 2023
@techsavvyash
Copy link
Collaborator

Hey @Deekshithrathod,
Can you fix the GHA script to create a .env using the .env.sample as well.

@Deekshithrathod
Copy link
Contributor Author

Sure, can do. Will update the PR by EOD

@Deekshithrathod
Copy link
Contributor Author

@techsavvyash Done.

  1. Updated GHA to make .env file from .env.example while testing PR
  2. How do you want to handle the documentation updation? I mean, do you want to create a separate issue or do you want me to make changes to 01-code-setup.md in this PR itself?

@Deekshithrathod
Copy link
Contributor Author

@techsavvyash Hey, made changes. Feel free to review & let me know if want me to change any commits.

@techsavvyash
Copy link
Collaborator

Hey @Deekshithrathod,
Have added a .env.sample in #101.

Can you update this PR to create a env based on that?

@Deekshithrathod
Copy link
Contributor Author

sure, can do.

@techsavvyash techsavvyash merged commit 710beb0 into ChakshuGautam:master Aug 1, 2023
@techsavvyash
Copy link
Collaborator

Hey @Deekshithrathod, thanks for the PR, have merged it.

@coveralls
Copy link

coveralls commented Oct 28, 2024

Pull Request Test Coverage Report for Build 5516310840

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 5228384560: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants