Ruff All the Things #1531
Merged
Ruff All the Things #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
We can start identifying them to allow for well-defined fail cases.
dokterbob
force-pushed
the
dokterbob/format_all_things
branch
from
918130f
to
094786b
Compare
willydouhard
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a number of improvements to the Python/backend linting/formatting, as well as many auto-generated fixes and formatting applied globally, to prevent gunk in future PR's.
In the process, I discovered that changed made by ruff's linter and formatters were not being added to commits, which was causing contributors a lot of frustration. I also discovered ruff was not properly configured and no actual linters were enabled, other than sorting of imports.
This PR includes:
a. A critical fixup regarding the new
Dataframeelement.b. Logging instead of ignoring arbitrary errors.
c. Upgrades to more modern Python syntax.