add the option vertexShaderCommon to prepend the custom vertexshader … #12327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request, @mickae1! Welcome to the Cesium community! In order for us to review your PR, please complete the following steps:
Review Pull Request Guidelines to make sure your PR gets accepted quickly. |
…with the PolylineCommon.glsl file
I've made what is needed : sign the CLA & edit the file CONTRIBUTORS.md |
|
Hi @mickae1, thank you for the proposal! We'll review this shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you want to set a custom shader, you have to include yourself all the content of the file PolylineCommon.glsl
Now with this option you can include it automatically when cesium is building the geometry.
By default the option is not activated and I've tested it with a developper tools in chrome.
It's very usefull because now I've only my code in the custom vertex shader.
Please review it, let me know if i've to change something.
Micka,