Updated to vcpkg version of cesium-native #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corybarr
reviewed
Sep 13, 2024
| @@ -1,5 +1,231 @@ | |||
| include(Macros) | |||
|
|
|||
| if(MSVC) | |||
There was a problem hiding this comment.
What if we set CESIUM_NATIVE_DEPENDENCIES here to include the common dependencies, then append the platform-specific ones? If we also do this in src/core/CMakeLists.txt, that cuts this list down from four occurrences to two.
There was a problem hiding this comment.
I'll see if we can do that, with the caveat that dependency order sometimes matters.
There was a problem hiding this comment.
Fixed in 1aaf653 with a slightly different approach
corybarr
reviewed
Sep 13, 2024
Is it worth creating an issue for this to improve how handoffable the build system is? I got stuck here, but also haven't managed complex CMake build systems professionally. |
|
Opened these follow up issues: |
corybarr
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the latest version of cesium-native, which now uses vcpkg.
Currently targeting the cesium-omniverse branch because of #727.
The ktx and asyncplusplus ports are copied directly from cesium-unity. The ktx port was especially important for fixing the release vs. debug VC runtime discrepancies we were seeing earlier.
Eventually would like to