Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding General Rules #7

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Adding General Rules #7

wants to merge 5 commits into from

Conversation

sarittenen
Copy link

No description provided.

Copy link
Contributor

@nd-certora nd-certora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, a few fixes, I can take another look after

],
"verify": "ERC20:certora/spec/general.spec",
"solc": "solc8.17",
"solc_args": [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove solc and solc_args

],
"verify": "Vault:certora/spec/general.spec",
"solc": "solc8.17",
"solc_args": [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove solc and solc_args

@@ -0,0 +1,122 @@
using DummyERC20A as erc20;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment:

/** General spec file that can used on any solidity contract, helps highlight the behavior or the contract **/

@@ -0,0 +1,9 @@
{
"files": [
"contracts/Vault.sol:Vault"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add ERC20.sol also


rule decreaseInERC20(method f) {

uint256 before = erc20.balanceOf(currentContract);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERC20Helper and then this support multiple erc20 , did this compile without using erc20?

Copy link
Contributor

@nd-certora nd-certora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small fixes

"certora/helpersContracts/ERC20helper.sol:ERC20Helper"
],
"verify": "ERC20:certora/spec/general.spec",
"solc": "solc8.17",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove solce, type in general

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants