Skip to content
This repository has been archived by the owner on May 22, 2023. It is now read-only.

Commit

Permalink
added/adjusted comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Andrei Navoichyk committed Apr 17, 2023
1 parent 65c9925 commit e65052c
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
3 changes: 3 additions & 0 deletions bin/node/cli/tests/running_the_node_and_interrupt.rs
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ async fn running_the_node_works_and_can_be_interrupted() {
run_command_and_kill(SIGTERM).await;
}

# The test is flaky (fixed in version polkadot-0.9.42)
# PR https://github.com/paritytech/substrate/pull/13505/files#diff-ebc30d2796db9889bdd0c10733b3ec29dec48b731f651d969c6612d68c39c832R72
# For now, we've increased the waiting time for blocks finalization from 30 to 45 seconds. From that moment on, the test never failed again.
#[tokio::test]
async fn running_two_nodes_with_the_same_ws_port_should_work() {
fn start_node() -> Child {
Expand Down
4 changes: 2 additions & 2 deletions client/beefy/rpc/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -248,9 +248,9 @@ mod tests {
);
}

#[tokio::test]
// Will be removed in commit https://github.com/paritytech/substrate/commit/abb80e54aa260514a4f12712a9ff8ef944e3b4ec
// Will be removed in version polkadot-0.9.25 (https://github.com/paritytech/substrate/commit/abb80e54aa260514a4f12712a9ff8ef944e3b4ec)
#[ignore]
#[tokio::test]
async fn subscribe_and_unsubscribe_to_justifications() {
let (rpc, _) = setup_io_handler();

Expand Down
4 changes: 2 additions & 2 deletions client/finality-grandpa/rpc/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -312,9 +312,9 @@ mod tests {
assert_eq!(expected_response, result);
}

#[tokio::test]
// Will be removed in commit https://github.com/paritytech/substrate/commit/abb80e54aa260514a4f12712a9ff8ef944e3b4ec
// Will be removed in version polkadot-0.9.25 (https://github.com/paritytech/substrate/commit/abb80e54aa260514a4f12712a9ff8ef944e3b4ec)
#[ignore]
#[tokio::test]
async fn subscribe_and_unsubscribe_to_justifications() {
let (rpc, _) = setup_io_handler(TestVoterState);
// Subscribe call.
Expand Down

0 comments on commit e65052c

Please sign in to comment.