Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6082] Fix two-factor authentication after Python 3.12 upgrade #81

Merged

Conversation

cslzchen
Copy link
Contributor

@cslzchen cslzchen commented Aug 8, 2024

Ticket

https://openscience.atlassian.net/browse/ENG-6082

Purpose

Fix two-factor authentication after Python 3.12 upgrade

Changes

  • Supports totp_secret in both HEX and plain string format
  • Improved exception handling

Dev Notes

N/A

QA Notes

  • Test existing 2FA works
  • Test newly created 2FA works

Dev-Ops Notes

N/A

Now it supports both pre and post python 3.12 upgrade
Both types of topt failures are now thown correctly
@cslzchen cslzchen requested a review from mfraezz August 8, 2024 20:11
@cslzchen cslzchen merged commit 2d48235 into CenterForOpenScience:develop Aug 8, 2024
1 check passed
@cslzchen cslzchen deleted the feature/fix-totp-secret branch October 7, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants