Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid geometry extraction proto + gRPC endpoints for Webviz #1

Open
wants to merge 60 commits into
base: dev
Choose a base branch
from

Conversation

jorgenherje
Copy link
Collaborator

@jorgenherje jorgenherje commented Apr 9, 2024

Grid geometry extraction functionality and endpoints for usage in Webviz. Proto files defining interface.


Closes: OPM#11199

sigurdp and others added 30 commits February 13, 2024 12:38
Make use of calculateCurrentTotalCellVisibility for eclipse view to get surface vertices. Prevent usage of individual grid part managers in gRPC-service.
- originUtm as 3D point changed to originUtmXy as 2D point.
- Have global z value for vertex coordinate in vertexArray
Read out of number of threads for OpenMP. Expected to be equal set environment variable OMP_NUM_THREADS
- Weld vertices to prevent duplicated nodes in vertex array.
- Handle welding of surface vertices and fault vertices separately.
- Adjust and remove python code
- Refactor welding in grid surface endpoint
- Add missing include
@jorgenherje jorgenherje added the enhancement New feature or request label Apr 9, 2024
@jorgenherje jorgenherje requested review from magnesj and sigurdp April 9, 2024 09:00
@jorgenherje jorgenherje self-assigned this Apr 9, 2024
@jorgenherje jorgenherje marked this pull request as ready for review April 11, 2024 14:19
@jorgenherje jorgenherje marked this pull request as draft April 12, 2024 05:36
Copy link

@magnesj magnesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well organized and easy to read PR. Appreciate the comment to explain intent related to the geometry functions.

Some minor whitespace and include issues should be fixed.

@jorgenherje jorgenherje requested a review from magnesj April 19, 2024 08:29
@jorgenherje jorgenherje marked this pull request as ready for review April 23, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grpc: Add extraction of surface geometry and intersection geometry
3 participants