forked from OPM/ResInsight
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid geometry extraction proto + gRPC endpoints for Webviz #1
Open
jorgenherje
wants to merge
60
commits into
dev
Choose a base branch
from
grid-geometry-extraction
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jorgenherje <[email protected]>
…rid-geometry-extraction
…rid-geometry-extraction
Make use of calculateCurrentTotalCellVisibility for eclipse view to get surface vertices. Prevent usage of individual grid part managers in gRPC-service.
…to grid-geometry-extraction
- originUtm as 3D point changed to originUtmXy as 2D point. - Have global z value for vertex coordinate in vertexArray
Read out of number of threads for OpenMP. Expected to be equal set environment variable OMP_NUM_THREADS
- Weld vertices to prevent duplicated nodes in vertex array. - Handle welding of surface vertices and fault vertices separately. - Adjust and remove python code
- Refactor welding in grid surface endpoint - Add missing include
magnesj
requested changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well organized and easy to read PR. Appreciate the comment to explain intent related to the geometry functions.
Some minor whitespace and include issues should be fixed.
...icationLibCode/ModelVisualization/Intersections/RivPolylineIntersectionGeometryGenerator.cpp
Outdated
Show resolved
Hide resolved
ApplicationLibCode/ModelVisualization/Intersections/RivPolylineIntersectionGeometryGenerator.h
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grid geometry extraction functionality and endpoints for usage in Webviz. Proto files defining interface.
Closes: OPM#11199