Better task manager #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # alab_management/task_actor.py # alab_management/task_manager/task_manager.py # alab_management/utils/data_objects.py
|
my review is ready |
In update_canceling_progress, the original_progress should be enum instead of the raw string.
|
@odartsi Thank you so much for your careful reviewing! I have updated the repo according to your comments and fixed some bugs in |
In update_canceling_progress, the original_progress should be enum instead of the raw string.
odartsi
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Include a summary of major changes in bullet points:
task manager(submit new tasks and cancel running tasks) andresource manager(handling resource requests)WAITINGorINITIATEDstatus. Now, the canceling can only happen if the task is inRUNNINGorREQUESTING_RESOURCESstatus.task_actor.py. Where the task will be first set toFINISHINGstate. Until all the procedure have been done, it will be set to corresponding ending status likeCOMPLETED,CANCELED, etc.load_definitionfunction. Previously, it is easy to import the alabos configuration folder multiple times. Now we add a__imported_modules__global variable to keep track of all the imported modules. If the package has been imported, it will be returned directly.test_launchunittest. Previously, it runs to start a virtual alabos server and submit one experiment. But it will not check the result (e.g. tracking the submitted experiment status). In this way, we can guarantee the whole module works as expected.pyproject.tomldependencies. Previously, there were a lot of duplicated dependencies in the project toml file. They are now removed and the existing dependencies have been updated to the right version.Additional dependencies introduced (if any)
No additional dependencies are introduced.
Checklist
Work-in-progress pull requests are encouraged, but please put [WIP] in the pull request
title.
Before a pull request can be merged, the following items must be checked:
The easiest way to handle this is to run the following in the correct sequence on
your local machine. Start with running black on your new code. This will
automatically reformat your code to PEP8 conventions and removes most issues. Then run
pycodestyle, followed by flake8.
Run pydocstyle on your code.
type check your code.
Note that the CI system will run all the above checks. But it will be much more
efficient if you already fix most errors prior to submitting the PR. It is highly
recommended that you use the pre-commit hook provided in the repository. Simply
cp pre-commit .git/hooksand a check will be run prior to allowing commits.