Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SampleView.update_sample_metadata(), plus a test #57

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

mattmcdermott
Copy link
Contributor

@mattmcdermott mattmcdermott commented Mar 13, 2024

Summary

Added a function for updating a Sample's metadata via the SampleView class.

This is introduced so that we can include metadata from tasks in the sample database. See #56

  • Code is in the standard Python style.
    The easiest way to handle this is to run the following in the correct sequence on
    your local machine. Start with running black on your new code. This will
    automatically reformat your code to PEP8 conventions and removes most issues. Then run
    pycodestyle, followed by flake8.
  • Docstrings have been added in theNumpy docstring format.
    Run pydocstyle on your code.
  • Type annotations are highly encouraged. Run mypy to
    type check your code.
  • Tests have been added for any new functionality or bug fixes.
  • All linting and tests pass.

@mattmcdermott mattmcdermott added the feature request new feature to implement label Mar 13, 2024
@mattmcdermott mattmcdermott added this to the v2024.03.18 milestone Mar 13, 2024
@mattmcdermott mattmcdermott self-assigned this Mar 13, 2024
@mattmcdermott mattmcdermott linked an issue Mar 13, 2024 that may be closed by this pull request
1 task
@mattmcdermott
Copy link
Contributor Author

mattmcdermott commented Mar 14, 2024

I'm going to merge this in myself since it doesn't affect any other features and all tests pass :) and I also need it right now to work on alab_one haha

@mattmcdermott mattmcdermott merged commit ad2f32c into main Mar 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request new feature to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Update Sample metadata convenience function
1 participant