creating the new mock decorator and updating the config file #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing the errors from previous commit
|
This PR is ready for merging in master |
idocx
reviewed
Dec 4, 2023
alab_management/config.py
Outdated
| @@ -83,7 +78,56 @@ def __init__(self): | |||
| ) from exc | |||
|
|
|||
| self._path = Path(config_path).absolute() | |||
| self._config = freeze_config(_config) | |||
| # self._config = freeze_config(_config) | |||
idocx
reviewed
Dec 5, 2023
| @@ -22,8 +22,8 @@ class Sample: | |||
| task_id: Optional[ObjectId] | |||
| name: str | |||
| position: Optional[str] | |||
| metadata: Optional[Dict[str, Any]] = field(default_factory=dict) | |||
| tags: Optional[List[str]] = field(default_factory=list) | |||
| metadata: Optional[Dict[str, Any]] = field(default_factory=lambda: None) | |||
There was a problem hiding this comment.
Why cannot it default to list/dict? That should be easier for searching in the MongoDB.
the config file can now be toggled depending on whether or not the workflow is run under the "simulation" mode.
2. removed the redundancy caused by two alab_management config files 3. removed redundant --sim_mode flags from cli
|
@idocx @bernardusrendy, can you pls review this PR and merge if possible? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Include a summary of major changes in bullet points:
Checklist
Before a pull request can be merged, the following items must be checked:
The easiest way to handle this is to run the following in the correct sequence on
your local machine. Start with running black on your new code. This will
automatically reformat your code to PEP8 conventions and removes most issues. Then run
pycodestyle, followed by flake8.
Run pydocstyle on your code.
type check your code.