Update TrackStatus from float to int (np.int64) #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note 2021 abu dhabi has num_laps = NaN
|
Thanks for the contribution! I am hesitant about merging this at the moment because I want to investigate what is causing the discrepancy in data type further. I am guessing this is because the data is fetched by different versions of Fastf1. Please leave this PR open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi hope it's alright if I (attempt to) contribute!
This is aimed to address #102
I removed all the transformed csv files and re-ran preprocessing.py (seems like you've already addressed the first task?) which seems to have addressed the second. For the third I removed the line which processes TrackStatus when it's a float (not sure if there's more you intended on changing here)