feat: allow calculateRoute and matchRoute to return rawResult #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also allow Valhalla matchRoute to not return `matched_points` (when only edges are requested)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes 2 changes:
rawResulttoRoutingResultandRouteMatchingResult. This allows to send any custom options to Valhalla and read the result as json string so that you can do anything with it without having to modifyRoutingResultandRouteMatchingResult. It is also very useful for cross plaftorm frameworks like React Native or Nativescript. The reason is that to pass the result to JS you only need to marshall a string and not a full structure of std vector and tons of data.RouteMatchingResultto have tomatched_points. Using custom parameters you can query only edge data. Without this PR it would throw because there is nomatched_points(which you actually did not ask for).