Skip to content
This repository has been archived by the owner on Aug 4, 2019. It is now read-only.

Feature/codeverification #20

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Feature/codeverification #20

wants to merge 16 commits into from

Conversation

miladsalimiiii
Copy link
Contributor

No description provided.

@miladsalimiiii
Create code verification layout , closed #9
1def390
@miladsalimiiii
Work on code verification view model , issue #11 , work on user repos…
3ade9c1 
…itory , issue #13 , work on retrofit configuration , issue #14 , work on code verification view , issue #10
@miladsalimiiii
Create fragment util , closed #17 , work on code verification view is…
9bc6909 
…sue #10 and code verification view model , issue #11 and add base view model
@miladsalimiiii
Create app module for DI , closed #19 , retrofit configuration , closed
8d284c5 
#14 , create user repository  , closed #13 , create verification code viewmodel , clsoed #11 , create verification code view , closed #10
@miladsalimiiii miladsalimiiii self-assigned this Jul 24, 2019
@HankMody69
Copy link

@miladsalimiiii
Hello my good friend the problems inside your development are listed below:

  1. Switch your theme to newer and recommended Theme.MaterialComponents.DayNight.NoActionBar
  2. After clicking button it turns into unreadable color
  3. Stylex.xml font styles are a little bit off, extend from MaterialDesign TextView
  4. [Optinal] Add initUiComponents to BaseFragment.kt
  5. In CodeVerificationFragment added many properties of views that never been used.
  6. FragmentUtil is a class that includes a single companion object? :|

@Miladsalimiiiii Miladsalimiiiii requested review from tina-t2 and ehsan-mashhadi and removed request for EhsanMashhadi and TinaT2 July 28, 2019 05:28
@Miladsalimiiiii
Copy link

@miladsalimiiii
Hello my good friend the problems inside your development are listed below:

1. Switch your theme to newer and recommended Theme.MaterialComponents.DayNight.NoActionBar

2. After clicking button it turns into unreadable color

3. Stylex.xml font styles are a little bit off, extend from MaterialDesign TextView

4. [Optinal] Add initUiComponents to BaseFragment.kt

5. In CodeVerificationFragment added many properties of views that never been used.

6. FragmentUtil is a class that includes a single companion object? :|

Hi dear Ramtin
1-It will be fix after merging
2-I do not face with this situation
3-It will be fix after merging
4-Fixed
5-If it does not use in my new feature branch i remove them
6-Fixed

@Miladsalimiiiii Miladsalimiiiii requested review from tina-t2 and ramtintk and removed request for HankMody69 July 28, 2019 09:29
@tina-t2 tina-t2 force-pushed the feature/codeverification branch from 164ecca to aded398 Compare July 29, 2019 06:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Miladsalimiiiii Miladsalimiiiii Miladsalimiiiii left review comments

@ramtintk ramtintk ramtintk approved these changes

@ehsan-mashhadi ehsan-mashhadi Awaiting requested review from ehsan-mashhadi

@tina-t2 tina-t2 Awaiting requested review from tina-t2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@miladsalimiiii @HankMody69 @Miladsalimiiiii @tina-t2 @ramtintk @ehsan-mashhadi