Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove system column "key" on filters #11

Open
wants to merge 1 commit into
base: 10.5
Choose a base branch
from

Conversation

zoidbergx
Copy link
Member

@zoidbergx zoidbergx commented May 2, 2023

Changes in this pull request

remove system column "key" on grid filters as the other system columns in grid.js
the system colums are defined in a constant in pimcore/bundles/AdminBundle/Controller/Admin/DataObject/DataObjectHelperController.php

const SYSTEM_COLUMNS = ['id', 'fullpath', 'key', 'published', 'creationDate', 'modificationDate', 'filename', 'classname'];

HOW

@github-actions
Copy link

github-actions bot commented May 2, 2023

Review Checklist

  • Target branch (10.5 for bug fixes, others 11.x)
  • Bug fix: check if files are affected that were moved to a bundle - create a PR there if applicable
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant