Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST: DO NOT MERGE] Long long fix mac test #192

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Commits on Nov 16, 2024

  1. add windows support to CMake

    TomMelt committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    516ea00 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. feat: set integer size for FTorch ftorch_int

    Integer size for FTorch can now be controlled using parameter
    `ftorch_int`.
    
    Currently, the default is set to `int32` but this could be changed if
    required.
    
    This fixes an issue on windows with the latest version of ifx/ifort
    which builds with a different integer type leading to the following
    error:
    
    ```
    error #6284: There is no matching specific function for this generic function reference.   [TORCH_TENSOR_FROM_ARRAY]
       in_tensors(1) = torch_tensor_from_array(in_data, tensor_layout, torch_kCPU)
    -------------------^
    ```
    TomMelt committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7856a33 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d64358c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b3b50a1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    594e938 View commit details
    Browse the repository at this point in the history
  5. bugfix: fix for windows and arm long long int

    fixes [#183](#183)
    
    There is an issue when building on mac (arm_64) or windows. The version
    of `libtorch` exposes a torch tensors shape (`t->sizes().data()`) as a
    `const long long int*` instead of just a `const long int*` like on linux
    and mac (x86).
    
    This commit adds preprocessor macro to switch between implementations
    automatically detecting the correct version at CMake build stage.
    TomMelt committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    5fb0887 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    472cc1c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    83101d6 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c9f9b01 View commit details
    Browse the repository at this point in the history