Add static analysis using fortitude, clang, and ruff #187
Conversation
jatkinson1000
force-pushed
the
static-analysis
branch
15 times, most recently
from
0063d5b
to
7c9d715
Compare
There was a problem hiding this comment.
Looks great! Happy for this to be submitted once a few small things are addressed.
The software citations for (Ruff, Fortitude, Clang-*, TorchFort, CAM-GW, ...) show as 'n.d' (no date) in the pdf. Does the 'year' attribute need to be set as well as the 'accessed' attribute? The date of access doesn't show in the references anyway.
Argh wrong PR!
Will review properly during the hackathon today. |
There was a problem hiding this comment.
This is a great contribution, thanks @jatkinson1000! A few comments and requested changes.
Worth noting that for nextSIM-DG we ended up pinning clang-format version 18 because the default settings sometimes change between versions and we hadn't set any of them in the config file (nor have you here, it seems).
jatkinson1000
force-pushed
the
static-analysis
branch
from
96b194d
to
3c4eab3
Compare
…nting tool versions).
jatkinson1000
force-pushed
the
static-analysis
branch
from
3c4eab3
to
11c8e4d
Compare
Add static analysis to the repo using: