Bump the minimum required CMake in all CMakeLists to 3.5 #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in a meeting users currently get a warning that CMake < 3.5 will be deprecated when building our code.
Since the minimum version that ships with many distros is above this (e.g. 3.26 on RHEL8) we can probably safely bump this to suppress the warning without issue.
Note that >3.5 may not be the minimum required version in actuality - we have not done an exhaustive test - but it was agreed that we should proceed this way until we receive an issue stating that it does not work on a particular version.