-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend FTorch to cover 5-dimensional tensors. #173
Conversation
As discussed over in #166 The tests for autograd were producing an error after this change, despite not touching them. This could be fixed locally on my machine by checking for However, the code is still failing the CI test here.
Update: See comment on #166 #166 (comment) and associated PR #174 This seems unrelated to the changes I have made here, so my suggestion is perhaps to turn the autograd test off for now and let this issue be resolved by #166 then turned back on. |
e2b581d
to
e66416f
Compare
I have just removed the commit that worked around the pointer issues that will be addressed by #175 This should now be merged after: |
e66416f
to
1305419
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single character change PR, love it!
Closes #172
We have had a request for 5D tensor support.
This is from the ConvLSTM: https://paperswithcode.com/method/convlstm which is a type of NN used to analyse gridded data.
Given our initial application (climate sciences) it would make sense to support this as standard.
I have extended the ranks argument in the fypp code to now support 5-D (rank 5) tensors.
One point to discuss is whether we want to support slightly higher in anticipation of other applications (Rank 6 or perhaps 7) bearing in mind that doing so adds quite a lot of code/functions in the f90 file.
We should also perhaps add documentation noting the limit in Rank, and perhaps describing how to extend it for specific cases.