Cleaning up pyo3 interface code and fixing docs #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went in just to fix a documentation error on the Time class, but this ended up being a bit of a rabbit hole.
This bumps the version of Pyo3 up to a more recent one, which caused a lot of knock-on effects. These led to having to update a fairly large chunk of the interface code, which was a significant improvements.
Details:
This also removed 2 intermediate enums on the rust side which only existed to allow polymorphic input support for the rust functions. These got replaced by custom
FromPyObject
pyo3 trait implementations, and I think overall made the code much cleaner.