Add Static Source checks and NEOS Individual Chips #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 24, 2024
|
Work remaining: cleanup some of the interface on the python side, add documentation and changelog. |
joemasiero
approved these changes
May 28, 2024
Comment on lines
+196
to
+205
| for ccd in chips.iter() { | ||
| if ccd.side_id != side_id | ||
| || ccd.stack_id != stack_id | ||
| || ccd.quad_id != quad_id | ||
| || ccd.loop_id != loop_id | ||
| || ccd.subloop_id != subloop_id | ||
| || ccd.exposure_id != exposure_id | ||
| || ccd.rotation != rotation | ||
| || ccd.observer().jd != observer.jd | ||
| || ccd.band != band |
There was a problem hiding this comment.
For item "ccd" in list(NeosCmos())? Technically fine, just a question of how pedantic do you want to be? maybe "for chip in chips.iter()"? or is that potentially confusing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Changed
1 million static points tiling the sky, with a single NEOS Visit FOV coloring the visible points.
Now at a higher lat
Rotated:
Static Source tests were also done with the ZTF fields, here are the first set of unique fields in 2018: