Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2010 TK7 trojan analysis example #126

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Add 2010 TK7 trojan analysis example #126

merged 2 commits into from
Sep 27, 2024

Conversation

dahlend
Copy link
Collaborator

@dahlend dahlend commented Sep 27, 2024

image

@dahlend dahlend merged commit ba639cc into main Sep 27, 2024
2 checks passed
@dahlend dahlend deleted the add-tk7 branch September 27, 2024 22:19
Copy link
Collaborator

@joemasiero joemasiero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the state propagation is quite right. I see now it's two_body, not n_body, but the frac*period_? part only will keep the right spacing if the periods are basically the same. If they are different, you can get drift between the JDs of state_a and state_b. I think you need to just clock the MA and then convert from elements to a state, then evaluate, rather than propagate


total = 0
for frac in np.linspace(0, 1, m_steps + 1)[:-1]:
state_a = kete.propagate_two_body([state_a], jd + (frac + shift) * period_a)[0]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not quite right. I don't believe you want to do propagation here. I think rather you want to sweep mean anomaly for the instantaneous orbits, then evaluate the state at each of those MA clockings. Time would be a third axis to consider; e.g. make one plot for time=jd, then integrate the jd of the system a step forward and make another plot.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.e., I'm not sure that this and the following line maintain the same delta-longitude for all steps in m_steps when period_a and period_b aren't the same, and I think you need to maintain that spacing to get the energy correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants