Wise fov rotation #110
Merged
Wise fov rotation #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlend
commented
Sep 5, 2024
| @@ -180,7 +180,7 @@ where | |||
| integrator.metadata, | |||
| )); | |||
| } | |||
| let mut next_step_size: f64 = 1.0_f64.copysign(integrator.final_time - integrator.cur_time); | |||
| let mut next_step_size: f64 = 0.1_f64.copysign(integrator.final_time - integrator.cur_time); | |||
There was a problem hiding this comment.
This tiny adjustment let to a reduction in 50km discretization noise on propagation near earth.
dahlend
commented
Sep 5, 2024
| @@ -156,8 +156,8 @@ impl From<fov::FOV> for AllowedFOV { | |||
|
|
|||
| #[pymethods] | |||
| impl PyWiseCmos { | |||
| #[new] | |||
| pub fn new( | |||
| #[staticmethod] | |||
There was a problem hiding this comment.
Keeping the old constructor, but downgrading it from the main constructor to just 'from_pointing'.
dahlend
commented
Sep 5, 2024
| patch, | ||
| observer, | ||
| frame_num, | ||
| rotation: f64::NAN, |
There was a problem hiding this comment.
I would have like to removed this variable, but backwards compatibility makes this not possible currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FOVs for WISE were being loaded as 0 degree rotations. This changes FOV construction to use the corners plus a little padding.
Along the way this also adjusts the integration initial guess step size from 1 day to 0.1 day, this GREATLY increases numerical stability when beginning propagation near a planet.