Fix single-step trap flag setting

Cacodemon345 · Jan 14, 2024 · 911deea · 911deea
1 parent 8c6fc11
commit 911deea
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 9 deletions.
diff --git a/src/cpu/386.c b/src/cpu/386.c
@@ -276,7 +276,7 @@ exec386_2386(int32_t cycs)
 #endif
                 opcode = fetchdat & 0xFF;
                 fetchdat >>= 8;
-                trap = cpu_state.flags & T_FLAG;
+                trap |= !!(cpu_state.flags & T_FLAG);
 
                 cpu_state.pc++;
                 x86_opcodes[(opcode | cpu_state.op32) & 0x3ff](fetchdat);

diff --git a/src/cpu/386_dynarec.c b/src/cpu/386_dynarec.c
@@ -300,7 +300,7 @@ exec386_dynarec_int(void)
             opcode = fetchdat & 0xFF;
             fetchdat >>= 8;
 
-            trap |= cpu_state.flags & T_FLAG;
+            trap |= !!(cpu_state.flags & T_FLAG);
 
             cpu_state.pc++;
             x86_opcodes[(opcode | cpu_state.op32) & 0x3ff](fetchdat);
@@ -871,7 +871,7 @@ exec386(int32_t cycs)
 #endif
                 opcode = fetchdat & 0xFF;
                 fetchdat >>= 8;
-                trap |= cpu_state.flags & T_FLAG;
+                trap |= !!(cpu_state.flags & T_FLAG);
 
                 cpu_state.pc++;
                 x86_opcodes[(opcode | cpu_state.op32) & 0x3ff](fetchdat);

diff --git a/src/io.c b/src/io.c
@@ -287,9 +287,6 @@ io_debug_check_addr(uint16_t addr)
     int i = 0;
     int set_trap = 0;
 
-    if (trap == 4)
-        return; /* Debug trap already pending. */
-
     if (!(dr[7] & 0xFF))
         return;
 

diff --git a/src/mem/mem.c b/src/mem/mem.c
@@ -168,9 +168,6 @@ mem_debug_check_addr(uint32_t addr, int write)
     int i = 0;
     int set_trap = 0;
 
-    if (trap == 4)
-        return; /* Debug trap already pending. */
-
     if (!(dr[7] & 0xFF))
         return;