Add an implementation of the proposed CRelocate instruction #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst not used inside the model, sail-cheri-riscv-verif will make use of this for properties relating to the upcoming CRelocate.
PeterRugg
approved these changes
Nov 14, 2022
arichardson
reviewed
Nov 14, 2022
There was a problem hiding this comment.
Commit message should probably reference CTSRD-CHERI/cheri-specification#3?
| * **tag** field cleared, and its **base** and **address* replaced with | ||
| * *cs1*.**base** $+$ *rs2* and *cs1*.**address** $+$ *rs2* respectively, | ||
| * subject to representability. If the resulting capability is not | ||
| * representable, the value of *rs2* as used for both calculations is |
There was a problem hiding this comment.
I find this sentence rather hard to parse
| function getRepresentableLength(len) : xlenbits -> xlenbits = { | ||
| let m = getRepresentableAlignmentMask(len); | ||
| (len + ~(m)) & m | ||
| } | ||
|
|
||
| function relocateCap(cap, offset) : (Capability, CapAddrBits) -> (bool, Capability) = { | ||
| let E = min(cap_max_E, unsigned(cap.E)); |
There was a problem hiding this comment.
This is a rather large and complex piece of code that looks like a close duplicate of other decoding code. I think this could either do with comments and/or share more code with getCapBoundsBits.
There was a problem hiding this comment.
Hm, parts of it do, but it's not clear how you'd really factor it out into a common function, I guess the only thing you could do is have an (a, B, T) -> (correction_base, correction_top) helper, if that's what you mean?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.