Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added image resize options to download #18

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

maxxer
Copy link
Contributor

@maxxer maxxer commented May 13, 2015

Requires himiklab/yii2-easy-thumbnail-image-helper

@maxxer maxxer mentioned this pull request May 13, 2015
@CTOlet
Copy link
Owner

CTOlet commented May 23, 2015

Something is wrong here. I cannot test that cause I have a memory limit when I try to print AttachmentsTable:

PHP Fatal Error – yii\base\ErrorException
Allowed memory size of 134217728 bytes exhausted (tried to allocate 14728 bytes)

That should not be cause 128 MB is enough

@maxxer
Copy link
Contributor Author

maxxer commented May 23, 2015

How many images did you have attached to the model? How big are they?
Maybe there's a memory leak in the EasyThumbnailImage::thumbnailImg call?
I tried with few images and worked fine...

@maxxer
Copy link
Contributor Author

maxxer commented May 23, 2015

I tried now with 6 images bigger than 2M each and I didn't have any problem in displaying the widget

@CTOlet
Copy link
Owner

CTOlet commented May 23, 2015

It's very strange behaviour of the script on my Mac. I still dont understand the problem. I have attached only one image with size of 150 KB

@maxxer
Copy link
Contributor Author

maxxer commented May 23, 2015

maybe php version? I tried on 5.5 and 5.6

@adiramardiani
Copy link

This is a great option when it comes true, why do not resize when you first insert to the database?

Sorry I was too stupid and could not pull request, but this time I saw a great resize behavior
mongosoft : UploadImageBehavior
zxbodya : ImageAttachmentBehavior

Whether it could be implemented here ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants