Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is a new pull request check it #16

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

This is a new pull request check it #16

wants to merge 4 commits into from

Conversation

hexl
Copy link

@hexl hexl commented May 10, 2015

if the file name is chinese, for example: 中文文件名测试.jpg
add '' to the file name when saving it to the move it to the temp folder.
remove the first '
' when insert the file name into database.

hexl added 4 commits May 9, 2015 23:52
add a char to the file name to fix chinese.
remove the first '_' added when save to temp folder; hexl 2015-05-09
@CTOlet
Copy link
Owner

CTOlet commented May 23, 2015

Bro, I have just tested that and I have not caught that error on my Mac. What OS do you use?

@hexl
Copy link
Author

hexl commented May 23, 2015

Windows Seven SP1 simple Chinese

@hexl
Copy link
Author

hexl commented May 23, 2015

if the file name is chinese file name, the pathinfo can not get the right file name.

@CTOlet
Copy link
Owner

CTOlet commented May 23, 2015

I have used chinese file name but have not seen any error

@CTOlet
Copy link
Owner

CTOlet commented Jun 19, 2015

Just now I have tested uploading and downloading on mac os and windows and have not seen that problem. When do you have that error? I can not understand you. My file name is 中文文件名测试.xlsx

@hexl
Copy link
Author

hexl commented Jun 19, 2015

@CTOlet
Copy link
Owner

CTOlet commented Jun 19, 2015

7 years ago?? Are you serious? Which version of the PHP do you use?

@hexl
Copy link
Author

hexl commented Jun 20, 2015

i use 5.4

@hexl
Copy link
Author

hexl commented Jun 20, 2015

the recent comments about file name
http://php.net/manual/vote-note.php?id=117298&page=function.pathinfo&vote=up

@CTOlet
Copy link
Owner

CTOlet commented Jun 20, 2015

Are you sure about 5.4? On http://php.net/manual/vote-note.php?id=117298&page=function.pathinfo&vote=up the bug is risen if you use 5.3

@hexl
Copy link
Author

hexl commented Jun 20, 2015

I'm sure. But i wonder if it's my php.ini or http.conf config error.
I found the bug in this framework.
https://github.com/liu21st/thinkphp/blob/master/ThinkPHP/Library/Think/Upload.class.php#L370

@CTOlet
Copy link
Owner

CTOlet commented Jun 22, 2015

So, do you solved the problem?

@hexl
Copy link
Author

hexl commented Jun 22, 2015

This PR has solved the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants