Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Allow implicit and explicit varianttype for mate #87

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Allow implicit and explicit varianttype for mate #87

merged 1 commit into from
Apr 26, 2019

Conversation

blankdots
Copy link
Contributor

Pull Request Template

Description

Related issues

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

  1. JSON schema for query to set in an explicit manner using both mateName and variantType=BND in a query.
  2. Docs with a note on this

Testing

  • Needs testing - most likely integration tests

Mentions

Discussed here: ga4gh-beacon/specification#278

@blankdots blankdots self-assigned this Apr 26, 2019
@teemukataja
Copy link
Contributor

JSON Schema shenanigans with funny logic.

@teemukataja teemukataja merged commit 7813dff into master Apr 26, 2019
@teemukataja teemukataja deleted the feature/mate-variant-conditional branch April 26, 2019 07:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@teemukataja teemukataja teemukataja approved these changes

Assignees

@blankdots blankdots

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blankdots @teemukataja