Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: store session info in localstorage #86

Merged
merged 2 commits into from
Nov 13, 2024
Merged

fix: store session info in localstorage #86

merged 2 commits into from
Nov 13, 2024

Conversation

solomonng2001
Copy link

  • try submitting code and refresh the browser
  • previously, the attempted status will be changed to not attempted on refresh
  • now, the attempted status will remain attempted on refresh

@solomonng2001 solomonng2001 self-assigned this Nov 13, 2024
UnwilledTangent
UnwilledTangent approved these changes Nov 13, 2024
View reviewed changes
Copy link

@UnwilledTangent UnwilledTangent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm. Session status does remain attempted after refresh. lgtm.

@bensohh
Copy link

bensohh commented Nov 13, 2024

I can confirm. Session status does remain attempted after refresh. lgtm.

@UnwilledTangent can you try to pull the same branch again and retest it? made a fix to the merge conflict

@UnwilledTangent
Copy link

testing now

@UnwilledTangent
Copy link

yep, does remain attempted

@solomonng2001 solomonng2001 merged commit e5642a7 into staging Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UnwilledTangent UnwilledTangent UnwilledTangent approved these changes

Assignees

@solomonng2001 solomonng2001

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@solomonng2001 @bensohh @UnwilledTangent