Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Collaboration Page #52

Merged
merged 10 commits into from
Oct 26, 2024
Merged

Conversation

bensohh
Copy link

@bensohh bensohh commented Oct 25, 2024

Implemented a Collaboration Page based on the route http://localhost:3000/collaboration/{matchId}

  • Utilise localstorage to pass matching information between pages (another method is passing through the url query parameters which is less ideal)
  • Implemented a simple signalling server in nodejs to handle the webrtc connections based on the example provided by yjs (Note: Remember to run this server first before testing collaboration feature)
  • Update local frontend .env variables to include signalling server
  • auto language detection works? (For python, go and javascript) but it is not the best implementation due to codemirror's limitation
  • Revamp the collaboration page to a cleaner ui/scss classnames

@solomonng2001 Can check out the TODOs under the following files:

  • apps/frontend/src/app/collaboration/[id]
  • apps/frontend/src/matching
    p.s: Some of the task might need to check with @tituschewxj on his PR merge for the match_found JSON changes
  • Wrap the end session in collaboration page to a modal to double confirm if user wants to quit/end session

Additional things to do:

  • Cleaning up signalling service (possibly linking with history service?)
  • Dockerizing signalling service
  • Making POST request for user session data
  • ...

@bensohh bensohh self-assigned this Oct 25, 2024
@solomonng2001
Copy link

@bensohh the collaboration looks great. Just 2 points

  • Noticed that the duration timer is not implemented yet
  • When one of the users ends the collaboration session, the session is not terminated for the other user

@solomonng2001
Copy link

@bensohh the collaboration looks great. Just 2 points

  • Noticed that the duration timer is not implemented yet
  • When one of the users ends the collaboration session, the session is not terminated for the other user

@bensohh noted that the 2 points highlighted are TODOs

Copy link

@solomonng2001 solomonng2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@solomonng2001 solomonng2001 merged commit 71a2ce1 into staging Oct 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants