Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error with cleaning up user from global maps #43

Merged
merged 2 commits into from
Oct 20, 2024
Merged

fix: error with cleaning up user from global maps #43

merged 2 commits into from
Oct 20, 2024

Conversation

bensohh
Copy link

@bensohh bensohh commented Oct 20, 2024

  • Cleanup the user from the global context and maps when users are matched
  • Improve the existing test websocket html page

@bensohh bensohh requested a review from tituschewxj October 20, 2024 07:45
@bensohh bensohh self-assigned this Oct 20, 2024
tituschewxj
tituschewxj approved these changes Oct 20, 2024
View reviewed changes
Copy link

@tituschewxj tituschewxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tituschewxj tituschewxj merged commit f8e0cda into staging Oct 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tituschewxj tituschewxj tituschewxj approved these changes

Assignees

@bensohh bensohh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bensohh @tituschewxj