Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend Websocket #40

Merged
merged 22 commits into from
Oct 20, 2024
Merged

Frontend Websocket #40

merged 22 commits into from
Oct 20, 2024

Conversation

chiaryan
Copy link

@chiaryan chiaryan commented Oct 18, 2024 •
edited
Loading

Integrate matchmaking service with matchmaking page and modal

TODO:

  • Allow retrying of match (storing and resending match settings)

Update:

  • handles new match_found response format
  • handles match_rejected by booting user to matchfinding modal and reports it via console.log

Update

  • include usernames under matched user profiles

chiaryan and others added 20 commits October 14, 2024 18:21
@chiaryan
Create and wrap application in context for state of socket
d212d68
@chiaryan
fix: remove "use client"
e6a169e
@chiaryan
Add usewebsocket, basic states for closed channel, open channel, and …
10da8f5 
…transition states
@chiaryan
Implement functionality for finding a match from message
dbafdf7
@chiaryan
Move websocket logic into services file, add states for finding match…
2557048 
… and timeout
@chiaryan
Merge branch 'staging' into frontend-websocket
82af041
@chiaryan
Merge branch 'staging' into frontend-websocket
354f47f
@chiaryan
Integrate useMatching interface with UI modals
79b3170 
TODO: retry matching
@chiaryan
bugfix: timeout did not direct correct model; hide retry buttons
d2270ba
@chiaryan
revert timeout value
8668971
@chiaryan
Merge branch 'ben/matching-service' into frontend-websocket
b0d0726
@chiaryan
Integrate with new matchmaking changes
c3714e1 
Also some fixes for timer display
@chiaryan
remove ValidateUserstub
404d5ad
@bensohh
Merge branch 'staging' into frontend-websocket
8782f31
@chiaryan
fix: .env.example uses incorrect url
1742ea6
@chiaryan
Merge branch 'frontend-websocket' of https://github.com/CS3219-AY2425…
f029e9a 
…S1/cs3219-ay2425s1-project-g24 into frontend-websocket
@chiaryan
Squashed commit of the following:
bd4d597 
commit 811261b
Author: Ryan Chia <[email protected]>
Date:   Sun Oct 20 14:18:24 2024 +0800

    2nd try

commit 99b08d8
Author: Ryan Chia <[email protected]>
Date:   Sun Oct 20 14:10:33 2024 +0800

    1st try
@chiaryan
Add handling of imporper match_found.
6247ae1 
Add handling of match_rejected
@chiaryan
Merge branch 'staging' into frontend-websocket
1d3afe7
@chiaryan
Remove imports from matching-service (was added during merge)
7c36043
@chiaryan
Copy link
Author

Update:

  • handles new match_found response format
  • handles match_rejected by booting user to matchfinding modal and reports it via console.log

solomonng2001
solomonng2001 approved these changes Oct 20, 2024
View reviewed changes
Copy link

@solomonng2001 solomonng2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@solomonng2001 solomonng2001 merged commit 0b5e5de into staging Oct 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solomonng2001 solomonng2001 solomonng2001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chiaryan @solomonng2001 @bensohh