Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create GitHub Actions for auto deployment to AWS #66

Merged
merged 10 commits into from
Nov 3, 2024
Merged

Create GitHub Actions for auto deployment to AWS #66

merged 10 commits into from
Nov 3, 2024

Conversation

McNaBry
Copy link

@McNaBry McNaBry commented Oct 29, 2024 •
edited
Loading

Description

  • Created a Github Actions workflow to push frontend files to AWS S3 bucket
  • Created a Github Actions workflow to push docker images to AWS ECR

Checklist

  • I have updated documentation
  • All tests passing

Screenshots (if applicable)

@McNaBry McNaBry force-pushed the ci-cd-aws-deploy branch 2 times, most recently from b809225 to 337a48e Compare October 30, 2024 03:01
@McNaBry McNaBry requested a review from samuelim01 October 30, 2024 04:45
samuelim01
samuelim01 reviewed Oct 30, 2024
View reviewed changes
Copy link

@samuelim01 samuelim01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, shall await the merge of #52 and #68. Also I can't seem to add a new secret with destroying the environment, so you might have to reconfigure the environment variables.

.github/workflows/frontend.yml Show resolved Hide resolved
@McNaBry
Add conditional trigger for backend workflow
63bb304 
* The build is triggered for a specific service only if its files have been changes
McNaBry and others added 2 commits October 31, 2024 13:51
@McNaBry
Update frontend workflow
57e3e74 
* Remove trigger on pull request
* Add conditional trigger based on frontend directory
@McNaBry @samuelim01
Add cloudfront cache invalidation to frontend workflow
c0b9e6d 
Co-authored-by: samuelim01 <[email protected]>
@McNaBry McNaBry requested a review from samuelim01 November 3, 2024 16:15
samuelim01
samuelim01 requested changes Nov 3, 2024
View reviewed changes
Copy link

@samuelim01 samuelim01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please standardise between backend_force.yml and frontend force.yml 🫡

@McNaBry McNaBry requested a review from samuelim01 November 3, 2024 16:27
samuelim01
samuelim01 approved these changes Nov 3, 2024
View reviewed changes
Copy link

@samuelim01 samuelim01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM good work!

@McNaBry McNaBry merged commit ccd3d92 into main Nov 3, 2024
11 checks passed
@McNaBry McNaBry deleted the ci-cd-aws-deploy branch November 3, 2024 16:39
KhoonSun47 added a commit that referenced this pull request Nov 3, 2024
@KhoonSun47
Merge branch 'main' into collab-page-enhancement-1
5bb85a2 
* main:
  Create GitHub Actions for auto deployment to AWS (#66)
  History Service (#69)
  Minor Fix To Handle isForfeit Status (#78)

# Conflicts:
#	services/collaboration/src/controllers/roomController.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelim01 samuelim01 samuelim01 approved these changes

Assignees
No one assigned
Labels
devops priority.Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@McNaBry @samuelim01