Organise env variables and authorization #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's pass the JWT_SECRET to the match service. This means only the user service will issue authorization tokens, but the service can verify the claims without depending on the user service.
Ensure that the creation, updating, and deletion of questions can only be done by admins.
KhoonSun47
added a commit
to KhoonSun47/cs3219-ay2425s1-project-g03
that referenced
this pull request
Oct 26, 2024
* main: Enhance Login & Registration Pages (CS3219-AY2425S1#57) Organise env variables and authorization (CS3219-AY2425S1#60) Add dozzle (CS3219-AY2425S1#59) # Conflicts: # .env.sample # compose.yml # services/match/.env.sample # services/match/src/events/broker.ts # services/question/src/models/index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spreading the use of environment variables across source files is messy and unmaintainable. Let's compact them into a single file, and use Zod to validate them upon service start up.
Asserting that authorization must be done by the user service creates a tight coupling between services. Let's pass the JWT_SECRET to each service, such that
Given that authorization is now handled within each service, let's
Checklist
Screenshots (if applicable)