Role based authorization spa #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Got user service to work in docker. It can only interface with an atlas cloud server currently.
User-service in docker can only communicate with an atlas mongodb server.
Some files should have been committed in the previous commit. They are mostly to do with the dockerisation process. The merge with main might have messed with it.
Somehow .gitignore was not commited with the last commit
Apparently bcrypt library cannot run on Docker's architecture. Change bcrypt to bcryptjs for compatibility.
Not connected to the login interface yet. Commiting to make a clean Pr.
* Remove orphan history file * Move `index.js` and `server.js` to the correct directory * Reduce use of port
Frontend is now able to POST to user login endpoint and receive a JWT token and some user details. These are stored in localStorage.
Some new files were untracked.
Right now if register is successful, it will auto login. Login if successful will bring users to the '/' directory. If user is already logged in, attemptes to reach '/account' will be immediately redirected to '/'
To keep it consistent with main, I have renamed files that are not part of app from filename to "_filename" out of app. I also cleaned up the outdated user-service because it was renamed already.
There was a duplicated of "user" in compose.yml.
Used ng generate guard to generate these.
Removed those _guards and implemented as a service instead. Added a guard to '/questions' so only logged in users with tokens that have not expired can access it. If they are not logged in, users will be directed to '/login' to log in.
Was magically missing from last commit.
- Removed user network (errornous merging). - Removed duplicate providers
Added interface for user service response.
Trying to figure out how to get status code from HttpClient with HttpResponse.
Realised that the error interceptor was mishandling the errors. Now it will throw an Error object with properties .message and .cause. Where message is the original error.message, and cause is just the original error itself.
Now, SPA will look different for admin and normal user. Also changed how it looks a little bit to make it look more tidy.
Removed some redundant files and fix with new api url.
changed *NgIf to use the newer @if. Bugs fixed include toolbar and table being of different sizes and clicking the "edit" button activates the sliding window.
There was a space between @ and if which broke the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional changes
Now '\questions' will query if user is admin. Many elements are now only loaded with ngIF* on this condition.
Admin view of '\questions':
User view of '\questions':
Changes to how '\questions' looks
Description is not hidden to a sliding panel and can be viewed by clicking on the row. This is to declutter the page.
Checklist