Enhance Login & Registration Pages #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add icons to the input field labels Remove primeNG password feedback and replace with password requirements list
McNaBry
force-pushed
the
enhance-login-registration
branch
from
ea11c33 to
c07a147
Compare
samuelim01
requested changes
Oct 21, 2024
* Remove weak password message * Conditionally render password list when user starts modifying the password field * Hide requirements and display a success message when user satisfies all requirements * Refactor code to render each requirement and improve naming for password validators
Previously, the submenu's position was not relative to the body, this causes the submenu to be out of position
samuelim01
reviewed
Oct 24, 2024
KhoonSun47
added a commit
to KhoonSun47/cs3219-ay2425s1-project-g03
that referenced
this pull request
Oct 26, 2024
* main: Enhance Login & Registration Pages (CS3219-AY2425S1#57) Organise env variables and authorization (CS3219-AY2425S1#60) Add dozzle (CS3219-AY2425S1#59) # Conflicts: # .env.sample # compose.yml # services/match/.env.sample # services/match/src/events/broker.ts # services/question/src/models/index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Screenshots (if applicable)