Question SPA #30

limcaaarl · 2024-09-22T10:09:51Z

Description

Added table view for the question data.
Dialogs and popups are implemented for adding/editing questions.
CRUD operations are currently implemented for client side only.

Checklist

Frontend
REST API calls
Update error messages
Allow addition of new topic

The new route is /questions

Currently, this delete only deletes questions from the client side.

…ay2425s1-project-g03 into init-primeflex

Previously, the multiselect would only show nulls when populated. Now, it would correctly show the right value.

Previously, pagination would not expand even if new rows were added

Question spa frontend

Lint Error

samuelim01

Looks pretty sick, other than the minor comments LGTM, just need to hook it with the question service endpoints.

frontend/src/app/questions/questions.component.spec.ts

frontend/src/app/questions/questions.component.ts

frontend/src/styles.css

samuelim01

woops missed two minor details

frontend/src/app/questions/questions.component.html

frontend/src/app/questions/questions.component.ts

- Update toast message for successful delete - Add spaces between multiple topics - Update .css to use .min - Remove redundant console logs

McNaBry

I can add a question with no topic even though it is stated to be required. I can achieve this by selecting one or more topics, then clearing the input. Pressing "save" then submits the question with no topic.

McNaBry · 2024-09-27T02:53:58Z

Can I also ask if question.service.ts can be moved outside of the question folder into a shared services folder? I think it might be required by other pages like matching where the list of possible topics have to be fetched from the DB.

limcaaarl · 2024-09-27T03:02:55Z

I can add a question with no topic even though it is stated to be required. I can achieve this by selecting one or more topics, then clearing the input. Pressing "save" then submits the question with no topic.

Thanks for pointing this one out. Fixed it 👍

limcaaarl · 2024-09-27T03:05:18Z

Can I also ask if question.service.ts can be moved outside of the question folder into a shared services folder? I think it might be required by other pages like matching where the list of possible topics have to be fetched from the DB.

I think this is still accessible by other pages since our frontend will be deployed as one. But if this improves the project structure, I can move it. What do the others think?

samuelim01 · 2024-09-27T03:29:03Z

Can I also ask if question.service.ts can be moved outside of the question folder into a shared services folder? I think it might be required by other pages like matching where the list of possible topics have to be fetched from the DB.

I think this is still accessible by other pages since our frontend will be deployed as one. But if this improves the project structure, I can move it. What do the others think?

I think we should move into src/_services/ or something along those lines as services are going to be used by many different components, so it would preferable for project structure.

samuelim01

Just a few minor things!

frontend/src/app/questions/questions.component.html

frontend/src/app/questions/questions.component.ts

frontend/src/app/questions/questions.component.html

frontend/src/app/questions/questions.component.ts

limcaaarl · 2024-09-27T06:45:55Z

Can I also ask if question.service.ts can be moved outside of the question folder into a shared services folder? I think it might be required by other pages like matching where the list of possible topics have to be fetched from the DB.

I think this is still accessible by other pages since our frontend will be deployed as one. But if this improves the project structure, I can move it. What do the others think?

I think we should move into src/_services/ or something along those lines as services are going to be used by many different components, so it would preferable for project structure.

Aite I'll move it to src/_services/ 👍

samuelim01

LGTM, just a few minor code quality comments

frontend/src/app/questions/question-dialog.component.html

frontend/src/app/questions/question-dialog.component.ts

frontend/src/app/questions/question-dialog.component.html

Upon adding a new topic, * Immediately adds the topic instead of the user having to press the new topic checkbox * Clear the search filter box since there would be no other results

@input

- Removed some of the @input in question-dialog - Updated ngIf to @if - Updated dialog box cancel button to use EventEmitter instead

- Fixed the issue where line break is not being shown in the description table - Fixed the issue where question becomes undefined after an error response is received, causing the form to be not prefilled upon clicking edit button

limcaaarl and others added 22 commits September 18, 2024 18:24

init question components

423a305

Add route for questions page

e15dd72

The new route is /questions

Add table component

e35083b

Fix primeflex import

b335b67

Add delete question event handling

330999c

Currently, this delete only deletes questions from the client side.

Merge branch 'init-primeflex' of https://github.com/limcaaarl/cs3219-…

2a21887

…ay2425s1-project-g03 into init-primeflex

Merge branch 'init-primeflex' into question-spa-frontend

7691aa8

Add dialog box for creating new question

6049982

Add edit button for each row

8ee7707

Add Prime Icons

19dfe9d

Fix edit bugs

0a9794f

Previously, the multiselect would only show nulls when populated. Now, it would correctly show the right value.

Fix spacing issues

a1eebb9

Fix row duplicate bug

398a915

Update question data to read locally

669c329

Fix pagination bug

6c3c4ea

Previously, pagination would not expand even if new rows were added

Reformat code for consistent indetation

7a8e2f4

Refactor classes and enums into separate files

807dc1b

Fix bug where selected row is not getting updated after edit

599addf

Remove redundant component

b0bae2a

Merge pull request #29 from limcaaarl/question-spa-frontend

56d7831

Question spa frontend

Fix lint error

25ce3b8

Merge pull request #31 from limcaaarl/question-spa-frontend

6aee0ac

Lint Error

limcaaarl linked an issue Sep 22, 2024 that may be closed by this pull request

Add Question SPA #9

Closed

limcaaarl added frontend priority.High labels Sep 22, 2024

samuelim01 reviewed Sep 23, 2024

View reviewed changes

frontend/src/app/questions/questions.component.html Outdated Show resolved Hide resolved

frontend/src/app/questions/questions.component.ts Outdated Show resolved Hide resolved

limcaaarl added 3 commits September 24, 2024 16:23

Merge branch 'main' into question-spa-frontend

68d682e

Update minor changes

6323496

- Update toast message for successful delete - Add spaces between multiple topics - Update .css to use .min - Remove redundant console logs

Fix indentations inconsistencies for .html files

78872ba

limcaaarl requested a review from KhoonSun47 September 27, 2024 02:10

Remove locally stored questions

1ddb1f9

McNaBry reviewed Sep 27, 2024

View reviewed changes

limcaaarl added 2 commits September 27, 2024 10:55

Update id column to be sortable

b84cb20

Fix topics field validation

efc6e14

samuelim01 reviewed Sep 27, 2024

View reviewed changes

frontend/src/app/questions/questions.component.html Outdated Show resolved Hide resolved

samuelim01 reviewed Sep 27, 2024

View reviewed changes

frontend/src/app/questions/questions.component.ts Outdated Show resolved Hide resolved

limcaaarl added 3 commits September 27, 2024 13:48

Update form errors to use the new Angular @if syntax

9e8fc42

Update to use formGroup.value instead of field listeners

60464d3

Fix dialog header text

129e4b0

limcaaarl added 5 commits September 27, 2024 14:50

Move question.service.ts to shared services folder

8ce20c2

Extract dialog box into a new component

e63f15c

Update topics dropdown to allow addition of new topics

6fc2041

Fix margin issue with dialog box

b5168bb

Fix css issue with add new topic button

4d03d12

samuelim01 approved these changes Sep 27, 2024

View reviewed changes

frontend/src/app/questions/question-dialog.component.html Outdated Show resolved Hide resolved

frontend/src/app/questions/question-dialog.component.ts Outdated Show resolved Hide resolved

frontend/src/app/questions/question-dialog.component.html Outdated Show resolved Hide resolved

samuelim01 and others added 5 commits September 28, 2024 00:21

Improve add new topic behaviour

4d3cb1c

Upon adding a new topic, * Immediately adds the topic instead of the user having to press the new topic checkbox * Clear the search filter box since there would be no other results

Fix minor issues

a4ea983

- Removed some of the @input in question-dialog - Updated ngIf to @if - Updated dialog box cancel button to use EventEmitter instead

Fix merge conflicts

4d25437

Fix bugs

ae4ba44

- Fixed the issue where line break is not being shown in the description table - Fixed the issue where question becomes undefined after an error response is received, causing the form to be not prefilled upon clicking edit button

Merge branch 'main' into question-spa-frontend

28dbdd2

limcaaarl merged commit 0db5a22 into main Sep 28, 2024
2 checks passed

samuelim01 deleted the question-spa-frontend branch September 29, 2024 03:45

limcaaarl self-assigned this Nov 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Question SPA #30

Question SPA #30

limcaaarl commented Sep 22, 2024 •

edited

Loading

samuelim01 left a comment

samuelim01 left a comment

McNaBry left a comment

McNaBry commented Sep 27, 2024

limcaaarl commented Sep 27, 2024

limcaaarl commented Sep 27, 2024

samuelim01 commented Sep 27, 2024

samuelim01 left a comment

limcaaarl commented Sep 27, 2024

samuelim01 left a comment

Question SPA #30

Question SPA #30

Conversation

limcaaarl commented Sep 22, 2024 • edited Loading

Description

Checklist

samuelim01 left a comment

Choose a reason for hiding this comment

samuelim01 left a comment

Choose a reason for hiding this comment

McNaBry left a comment

Choose a reason for hiding this comment

McNaBry commented Sep 27, 2024

limcaaarl commented Sep 27, 2024

limcaaarl commented Sep 27, 2024

samuelim01 commented Sep 27, 2024

samuelim01 left a comment

Choose a reason for hiding this comment

limcaaarl commented Sep 27, 2024

samuelim01 left a comment

Choose a reason for hiding this comment

limcaaarl commented Sep 22, 2024 •

edited

Loading