Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for Minor Code Revision for CS3219 Project #102

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KhoonSun47
Copy link

@KhoonSun47 KhoonSun47 commented Nov 15, 2024

Description

This Pull Request addresses an issue identified in our tsconfig.json file located at root/services/collaboration/src. The issue is preventing our collaboration service from compiling correctly. To resolve this, we propose adding these 2 lines of codes:

"allowJs": true,
"include": ["**/*.ts", "**/*.js"]

Context

Earlier this morning, my team (CS3219 Group 03) had a demo with Dr. Akshay using the deployed version of our PeerPrep website, which worked correctly. However, the latest commit on the repository caused a compilation issue in our collaboration service. This would impact the ability of the TA and Professor to test our code locally once we take down our deployed site to avoid exceeding our credit limit.

I have discussed this matter with TA Vishruti, and she advised us to create this PR with the proposed change for review.

Checklist

  • All tests passing

@KhoonSun47 KhoonSun47 added this to the Milestone 7 milestone Nov 15, 2024
@KhoonSun47 KhoonSun47 requested review from limcaaarl and samuelim01 and removed request for limcaaarl and samuelim01 November 15, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant