Timeout on GPGraph construction in GreedyPauliSimp
#1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unneeded
cqc-alec
reviewed
Dec 5, 2024
tket/test/src/test_GreedyPauli.cpp
Outdated
| .apply(d)); | ||
| REQUIRE(Transforms::greedy_pauli_optimisation( | ||
| 0.7, 0.3, 500, 500, 0, true, 10, 10) | ||
| 0.7, 0.3, 500, 500, 0, true, 10000, 10) |
There was a problem hiding this comment.
I don't think we should make the tests take much longer. I suggest removing the test with the long timeout (or annotating it with [.long] so that it doesn't run by default.
There was a problem hiding this comment.
done! I've changed the loop size to make the circuit a 1/5 of the size
| /** Construct an GPGraph from the circuit size */ | ||
| GPGraph(qubit_vector_t qubits, bit_vector_t bits); | ||
|
|
||
| GPGraph get_graph( |
There was a problem hiding this comment.
Can you document what this function does?
There was a problem hiding this comment.
Ah, that method shouldn't even be there & is a leftover from an alternative way I considered doing this. I've removed it!
Co-authored-by: Alec Edgington <[email protected]>
…m/CQCL/tket into add-timeout-to-graph-construction
cqc-alec
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GPGraphconstruction andGPGraph::get_sequencecan run significantly longer than the given timeout. This PR updatesgreedy_pauli_graph_synthesis_flagto check timeout during the execution of these methods and to finish early if the timeout is met.Related issues
Please mention any github issues addressed by this PR.
Checklist