-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ros2 Topic Based RTCM publisher #9
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConnorNeed
requested review from
ChrisRusu1,
noodlekid and
DeclanMcIntaggart
December 15, 2024 21:30
noodlekid
requested changes
Dec 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few changes that would help with maintainability, otherwise I like it.
noodlekid
reviewed
Dec 15, 2024
ConnorNeed
force-pushed
the
connor-gps
branch
from
December 31, 2024 21:27
acbd6dc
to
e477e8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Node attempts to take a different approach to than what we have been working on over the past 2 months. This approach is a little more custom since we had to implement this node. However it is a much cleaner architecture utilizing the power of ros2 topics. I still want to develop both methods and then compare field testing results for accuracy, reliability, ect.
New functionality:
src/gps/gps/rtcm_pub_node.py
: AddedRtcmNode
class for managing RTCM data via serial communication and publishing it to the/rtcm
topic. This includes serial I/O operations, parameter loading, and RTCM message configuration.Launch files:
src/gps/launch/basestation.launch.py
: Added launch file to start thertcm_pub_node
and other related nodes with specified parameters.Testing:
I ran the node and the parsed data that gets logged makes sense and there are raw values being published to the topic. However we can not say for certain if it works until we configure a node such as https://github.com/KumarRobotics/ublox/tree/ros2 and actually test it with two receivers. I will do this when we come back in January.