Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ros2 Topic Based RTCM publisher #9

Closed
wants to merge 12 commits into from
Closed

Ros2 Topic Based RTCM publisher #9

wants to merge 12 commits into from

Conversation

ConnorNeed
Copy link
Contributor

This Node attempts to take a different approach to than what we have been working on over the past 2 months. This approach is a little more custom since we had to implement this node. However it is a much cleaner architecture utilizing the power of ros2 topics. I still want to develop both methods and then compare field testing results for accuracy, reliability, ect.

New functionality:

  • src/gps/gps/rtcm_pub_node.py: Added RtcmNode class for managing RTCM data via serial communication and publishing it to the /rtcm topic. This includes serial I/O operations, parameter loading, and RTCM message configuration.

Launch files:

Testing:

I ran the node and the parsed data that gets logged makes sense and there are raw values being published to the topic. However we can not say for certain if it works until we configure a node such as https://github.com/KumarRobotics/ublox/tree/ros2 and actually test it with two receivers. I will do this when we come back in January.

Copy link
Contributor

@noodlekid noodlekid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes that would help with maintainability, otherwise I like it.

src/gps/gps/rtcm_pub_node.py Outdated Show resolved Hide resolved
src/gps/gps/rtcm_pub_node.py Outdated Show resolved Hide resolved
src/gps/gps/rtcm_pub_node.py Outdated Show resolved Hide resolved
src/gps/gps/rtcm_pub_node.py Outdated Show resolved Hide resolved
src/gps/gps/rtcm_pub_node.py Outdated Show resolved Hide resolved
src/gps/gps/rtcm_pub_node.py Show resolved Hide resolved
src/gps/gps/rtcm_pub_node.py Outdated Show resolved Hide resolved
src/gps/launch/basestation.launch.py Show resolved Hide resolved
@CPRT CPRT locked and limited conversation to collaborators Dec 21, 2024
@CPRT CPRT unlocked this conversation Dec 21, 2024
@ConnorNeed ConnorNeed closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants