Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apis init #3

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

apis init #3

wants to merge 29 commits into from

Conversation

SanchitEsMagico
Copy link
Collaborator

No description provided.

kh4l1d64
kh4l1d64 reviewed Sep 25, 2023
View reviewed changes
src/user/user.service.ts Outdated Show resolved Hide resolved
kh4l1d64
kh4l1d64 requested changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@kh4l1d64 kh4l1d64 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments and suggestions. Also recommend adding unit tests for apis

Ajay-Maury
Ajay-Maury requested changes Sep 26, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
prisma/migrations/20230921053937_wallet_user_id_uniq/migration.sql Outdated Show resolved Hide resolved
prisma/migrations/20230921071650_transaction_type/migration.sql Outdated Show resolved Hide resolved
src/admin/admin.controller.ts Outdated Show resolved Hide resolved
src/admin/admin.controller.ts Outdated Show resolved Hide resolved
src/admin/admin.service.ts Outdated Show resolved Hide resolved
src/provider/provider.service.ts Outdated Show resolved Hide resolved
src/transactions/dto/transactions.dto.ts Outdated Show resolved Hide resolved
src/user/user.controller.ts Outdated Show resolved Hide resolved
src/transactions/transactions.service.ts Show resolved Hide resolved
aman1esmagico
aman1esmagico requested changes Sep 26, 2023
View reviewed changes
src/admin/admin.controller.ts Outdated Show resolved Hide resolved
prisma/schema.prisma Show resolved Hide resolved
src/provider/provider.service.ts Outdated Show resolved Hide resolved
src/provider/provider.service.ts Outdated Show resolved Hide resolved
src/user/user.controller.ts Outdated Show resolved Hide resolved
@geeky-abhishek
Copy link

Waiting for the changes to be resolved.Also please add documentation & flow diagrams in all PRs.

@COMPASS-DPG COMPASS-DPG deleted a comment from aman1esmagico Oct 10, 2023
@COMPASS-DPG COMPASS-DPG deleted a comment from aman1esmagico Oct 10, 2023
@SanchitEsMagico
Copy link
Collaborator Author

@geeky-abhishek I have added the documentation for use cases and the link for the flow diagram

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ajay-Maury Ajay-Maury Ajay-Maury requested changes

@kh4l1d64 kh4l1d64 kh4l1d64 requested changes

@aman1esmagico aman1esmagico aman1esmagico requested changes

@VamshiBatta07 VamshiBatta07 Awaiting requested review from VamshiBatta07

@prashantesmagico prashantesmagico Awaiting requested review from prashantesmagico

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SanchitEsMagico @geeky-abhishek @Ajay-Maury @aman1esmagico @kh4l1d64 @SanchitUke @VamshiBatta07