Various bug fixes #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 21, 2020 21:40
The value will explode when there is actually no requests destined for that queue. Should do a sanity check
In the rare case that Simulator->Time() < SIM_TIME_TO_SECONDS_COEFF, the XML output will be inf due to dividing by zero
* The missing return causes the WRITE_CACHE switch branch to fall into the default branch, causing an error * Fix memory leak
if the user attempts to read a page that has never been written before, its LPA might be overwritten by NO_LPA. Check this corner case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix wrong average queue waiting time
The value will explode when there is actually no requests destined for that queue. Should do a sanity check
cache manager
WRITE_CACHEswitch branch to fall into the default branch, causing an errorprevent garbage address when reading unwritten page
if the user attempts to read a page that has never been written before, its LPA might be overwritten by NO_LPA. Check this corner case