Continued Geom Dev #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- warnings appear for lineend and linejoin - need to make conditional - need to determine what data must look like to work
Not standard, will not display in legend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR seeks to further optimize the use and structure of Geoms in this package, as well as to add some additional features. Currently in draft.
Proposed Changes
List changes below in bullet format:
layer()is called in the constructor function instead of inggplot_add(). This gives the benefit of auto-tabbingaes()params (including custom ones like ingeom_swim_label()), and warnings associated with the true function instead ofggplot_add()as brought up in [BUG]ggplot_add.()Instead of Parent Function in Default Error Messages #46geom_swim_lane()that add points onto thelinewidthofgeom_swim_lane().Remaining TODOs:
geom_swim_arrow()to same structure, a little tricky with how we manipulate data/mappingFormalize and fixindicator_*params ingeom_swim_label()to appear in legend as submitted in [FEATURE] Offset Indicators for Segments #45Issues Addressed
ggplot_add.()Instead of Parent Function in Default Error Messages #46Known Issues
geom_swim_arrow()aes()does not autofillgeom_swim_arrow()requiresdatato be specified in current method to allow for proportionalarrow_neck_lengthwhen val isNULL