Assuring RDRS ends properly #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, two concerns are addressed: 1) for small domains some times, the process ends without actually doing the job and 2) using ncks and index-based hyperslab to extract a spatial subset. For the former concern, a `until ... do` loop is used to assure each process on each file is finished properly. Furthermore, proper error messages are thrown at the user. For a simply case of `Bow River at Banff`, where the final NetCDF files are in the magnitute of a few kilobytes, the script was not behaving properly before. This behaviour is as expected with this commit. For the latter concern, the `ncks` is used to avoid using `cdo`. `ncks` proves to be more stable and reliable. Signed-off-by: Kasra Keshavarz <[email protected]>
This was referenced Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, two concerns are addressed: 1) for small domains some times, the process ends without actually doing the job and 2) using ncks and index-based hyperslab to extract a spatial subset.
For the former concern, a
until ... doloop is used to assure each process on each file is finished properly. Furthermore, proper error messages are thrown at the user. For a simply case ofBow River at Banff, where the final NetCDF files are in the magnitute of a few kilobytes, the script was not behaving properly before. This behaviour is as expected with this commit.For the latter concern, the
ncksis used to avoid usingcdo.ncksproves to be more stable and reliable.Signed-off-by: Kasra Keshavarz [email protected]