Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #12

Closed
wants to merge 6 commits into from
Closed

Refactor #12

wants to merge 6 commits into from

Conversation

mathisdrn
Copy link
Contributor

No description provided.

@mathisdrn mathisdrn requested a review from youen August 23, 2023 14:07
Copy link
Collaborator

@youen youen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no fix in the code

@@ -0,0 +1 @@
{"EMAIL":"[email protected]","GROUPE_ID":3,"ID":61,"ID_TYPE_UTILISATEUR":null,"LOGIN":"HELPDESKLBP","MDP":"HELPDESKLBP","NOM":"BRUNET","PRENOM":null,"PROFIL_ID":2}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please mask MDP and LOGIN field with "*"

count: 1
unique: 1
sample:
- HELPDESKLBP
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update report with masked values

@mathisdrn
Copy link
Contributor Author

mathisdrn commented Aug 24, 2023

Refactor :

  • better architecture, each package have a precise role
  • analyse.go now builds model.Base with pointer : SetGenericMetric(), SetBoolMetric(), etc.

Features :

  • jsonschema command and venom test
  • added GPL v3 to all files

Fix :

  • analyse pipeline should now handles nil values found in slice of interface
  • countUnique, unique, sample now works together with T comparable

Test:

  • added test for new function

Benchmark :

  • better scope of benchmarking

Performance :

  • improved (about 20%)

Build.yaml :
benchmark are saved bin/coverage_benchmark.txt while test are saved bin/coverage.txt

Possible future enhancements :

@mathisdrn mathisdrn changed the title null values bug - Cannot reproduce error Refactor Aug 24, 2023
@mathisdrn mathisdrn closed this Aug 24, 2023
@mathisdrn mathisdrn deleted the mathisdrn/issue11 branch August 24, 2023 12:55
@mathisdrn mathisdrn restored the mathisdrn/issue11 branch August 24, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants